Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve workspace selection screen #5853

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

chore: Improve workspace selection screen #5853

wants to merge 12 commits into from

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Sep 3, 2024 •
edited
Loading

Proposed changes

Some small tweaks to workspace selection screen, forget password screen

Issue(s)

How to test or reproduce

Screenshots

image

iPad
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

MA-84

@yash-rajpal yash-rajpal marked this pull request as ready for review September 3, 2024 19:16
diegolmello
diegolmello requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also paste a screenshot of iPad with the new logo?

app/i18n/locales/en.json Show resolved Hide resolved
app/views/ForgotPasswordView.tsx Outdated Show resolved Hide resolved
app/views/NewServerView/index.tsx Outdated Show resolved Hide resolved
@yash-rajpal
Copy link
Member Author

Let me check the breaking E2E tests and update them accordingly.

@diegolmello
Copy link
Member

@yash-rajpal Make sure to review styles again. It's still not quite like Figma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello Awaiting requested review from diegolmello

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-rajpal @diegolmello