Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update react-native-mmkv-storage to 0.8.0 #4695

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Nov 18, 2022

Proposed changes

Bumps react-native-mmkv-storage and possibly fixes #4431, because it lands this fix ammarahm-ed/react-native-mmkv-storage#263

Issue(s)

How to test or reproduce

  • Update app should keep the user logged in
  • Share media from other apps to Rocket.Chat
  • Reply from push notification
  • Secured Push Notification (fetch content push)
  • Decrypt push notification
    • Enable E2E encryption and receive push notifications

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-164

@diegolmello diegolmello marked this pull request as ready for review November 18, 2022 20:30
@ankar84
Copy link
Contributor

ankar84 commented Jan 16, 2023

We are enabled Secured Push on recently updated 5.4.1 server version and test that on 4.34 mobile version.
Users says that #4199 still an issue on 4.34. So, that problem not completely fixed by that PR.
Actually as for me - I have all push notification with full message text on iPhone during Secured Push test.

@diegolmello
Copy link
Member Author

@ankar84 I'm not sure I've followed.
Is it working on Android?
Is it working on iOS only for you?
Is that it?

ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log in bug: Having to uninstall app on IOS
2 participants