update to Electron 34

RocketChat · Jan 22, 2025 · 6dfcc31 · 6dfcc31
1 parent 1106a88
commit 6dfcc31
Show file tree

Hide file tree

Showing 3 changed files with 520 additions and 159 deletions.
diff --git a/package.json b/package.json
@@ -109,8 +109,8 @@
     "chokidar": "~3.5.3",
     "conventional-changelog-cli": "~4.1.0",
     "convert-svg-to-png": "~0.6.4",
-    "electron": "31.6.0",
-    "electron-builder": "24.13.3",
+    "electron": "34.0.0",
+    "electron-builder": "25.1.8",
     "electron-devtools-installer": "^3.2.0",
     "electron-notarize": "^1.2.2",
     "eslint": "~8.56.0",

diff --git a/src/ui/main/rootWindow.ts b/src/ui/main/rootWindow.ts
@@ -257,8 +257,8 @@ export const setupRootWindow = (): void => {
 
     rootWindow.addListener('close', async () => {
       if (rootWindow?.isFullScreen()) {
-        await new Promise((resolve) =>
-          rootWindow.once('leave-full-screen', resolve)
+        await new Promise<void>((resolve) =>
+          rootWindow.once('leave-full-screen', () => resolve())
         );
         rootWindow.setFullScreen(false);
       }