Create mocks to call accessors from Deno #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2023
Merged
d-gubert
force-pushed
the
deno/proxied-accessors
branch
from
a16bf02 to
68e8993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
We need to create accessor mocks in Deno that will call the Node process.
The mocks can be proxies that will issue a Request message to the Node process that will actually perform the method call in the appropriate accessor, returning a Promise that will resolve when Node sends a Response message to the initiating Request.
On the Apps-Engine runtime, this request will be handled by the DenoRuntimeSubprocessController instance associated with the originating subprocess
Why? 🤔
Links 🌎
PS 👀