-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance add link modal and disabling message items while typing #809
base: develop
Are you sure you want to change the base?
Conversation
Please attach a video/screenshot of the Add Link modal as well. |
It's already shown in the screencast attached above |
Got it. Can we remove the placeholders? Since you added labels, users will know what to type inside them. Regarding the labels, since it's a Link Window and we're only interacting with the link (not any other functionality), users will understand that the 'Text' and 'URL' refer to the link. There's no need to specifically label them as 'Link Text' and 'Link URL'. Also, I think it would be nice to stay consistent with Rocket.Chat channel terminology, using only 'Text' and 'URL'. |
Got it! |
2ef2985
to
8f3bb40
Compare
Resolve conflicts |
Done. |
Brief Title
Enhance add link modal and disabling message items while typing
Acceptance Criteria fulfillment
Fixes #808
Video/Screenshots
Screencast.from.2025-01-16.23-16-15.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-809 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.