-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ChatInput Formatter Tool UI for small screens #693
base: develop
Are you sure you want to change the base?
Conversation
Hey @abirc8010 it looks very good, but a suggestion you just put only formatters in that 3 dot menu. it would be better for user to find audio, video, and file upload buttons if they are displayed and visible on chatformatting toolbar. also you can see in layout editor, the formatters are not adjustable, and audio video and file upload are adjustable. the code I shared to you in that merged pr is based on this feature |
@devanshkansagra I have considered moving the video and files to 3-dot menu so that clicking the audio message does not cause other icons (video, file) to be shifted outside the toolbar. Screencast.from.2024-12-18.11-16-22.webm |
then it might be difficult to edit layout of embeddedchat using layout_editor, or else do one thing, try to remove the margins from sides(left and right) of chat input box on small screen keeping only formatters in 3 dots. just for visualization how it would look, whether it will look consistent or not? |
Screencast.from.2024-12-19.00-36-52.webm@devanshkansagra @Spiral-Memory will it be ok to make the message box occupy the entire width ? |
Hi @abirc8010 and @devanshkansagra , Let’s make it configurable. In mobile mode, let the user (the one setting up EC) decide what they want to keep visible and which options should go into the three-dot menu, similar to how this is configurable in the theme object. @devanshkansagra , maybe you can connect with @abirc8010 to guide him on this or collaborate together on it. |
Sure |
Hey @devanshkansagra @Spiral-Memory Screencast.from.2024-12-24.14-18-10.webm |
Brief Title
Moved formatters, video and file attachment to popover menu for small screens
Acceptance Criteria fulfillment
@media(max-width: 400px)
) to render the VideoMessageRecorder inside the popover.Video/Screenshots
Screencast.from.2024-12-19.00-36-52.webm
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-693 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.