fix: issue of mentioning the user in the file description #677
Conversation
|
Hey @SinghaAnirban005, I was previously working on the Markdown issue and I got some relations of that issue and this issue, so I instantly got approach and I raised the pr. But don't worry you can review this pr and suggest me any changes required. Also I have one issue correlated to this issue. You remember I have asked you about whether the userinfo is displayed or not when clicking on the mention. I observed that, it is also not working in chatinput also if you mention a user. so you can raise the issue and create a pr for that |
|
@devanshkansagra Your changes look good, Just wanted to ask whether on mentioning other users , the highlight colour changes to greyish ?? Also once your changes are approved I will start working on the issue where the user info is not displayed |
|
yepp it changes, Basically I used the Markdowns in the AttachmentPreview and accordingly it will work as how the mentioning in chatinput work |
devanshkansagra
changed the title
|
Hey @Spiral-Memory, can you approve this pr to test and review this pr? |
|
Hi @devanshkansagra, In the video, I noticed that opening the username preview disturbs the orientation of the modal. Additionally, the preview only covers the length of the username. Could you adjust it to cover the full length, similar to the message box? Instead of increasing the modal height, could we try to make the preview overlap with the above containers so that it doesn’t affect the modal size? |
|
Ok Noted.. |
devanshkansagra
force-pushed
the
fix-issue#622
branch
from
b6b4840 to
7c90232
Compare
|
Hey @Spiral-Memory , I have noticed some inconsistency regarding mentioning in a user in a quoted file message, I will append that fix commit in this pr as it is related to this issue |
|
In the quoted messages, the mentions are displayed as a plain text because, inside a quote message there is no message object, instead there are inner attachments, also this is the same behaviour in rocketchat main. so I kept as it is |
|
Hey @Spiral-Memory, can you review this also, I have made the appropriate changes you suggested |
|
yea but that was also a new pr for that workflow and also that security alert was not interfering in that workflow, then how it is possible? |
|
Okay no worries |
|
Before :
After:
Pls make a fix for that |
|
|
|
Check my message, how one text is above another. |
|
oh okay that is just one line padding fix, I will add that commit |
|
Ok, add the fix |
|
Hey @Spiral-Memory, I have fix this minor issue, you can approve to check and review the code, if everything look good then merge it |
Fixed the issue of rendering mentions in file description
Acceptance Criteria fulfillment
userorallorhererenders properly even when mentioning with@in the file descriptionFixes #622
Closes: #648
Video/Screenshots
Screencast.from.16-12-24.02.00.35.PM.IST.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-677 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.