Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created in response to the TODO in
SignedMessageForm
, in the middle of the button click which triggers an API call.rescue-ui/src/components/SignedMessageForm.tsx
Lines 117 to 142 in 98a6fa9
I took the liberty of just generally "cleaning up" the Api object, to enforce more proper typing for requests and responses (no more
any
s), as well as consolidate all data parsing and error handling into the shared internalrpc
function.Other auxiliary changes in this PR include:
npm run dev
console.SignedMessageForm
component