Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RAC Style Library into Aurora #683

Open
wants to merge 121 commits into
base: development
Choose a base branch
from
Open

Conversation

HaSistrunk
Copy link
Member

@HaSistrunk HaSistrunk commented Sep 20, 2024

fix #555
fix #658
fix #646
fix #664
fix #668
fix #700

Implements the RAC Style Library into Aurora including substantial UI redesign and app updates.

  • Remove Bootstrap and AdminLTE styles
  • Remove moment.js for datatables (machine_file_upload_time data is already defined via models and views in the format we display it in, so unless I'm missing something we don't need to define a date format in the templates).
  • Use micromodal.js for modals instead of Bootstrap JS.
  • Update Datatables.js to version 2.1.8 and jquery 3.7.1, including updating Datatables implementation to align with more recent version. Evaluated alternatives with search and pagination options including Grid.js and Tabulator, but Datatables still seems to be the best option in terms of functionality and accessibility.
  • Pull in Datatables css, but customize to update table cell padding, the sort icon styles for better contrast, and adjust search/select input widths to work with RAC styles.
  • Use RAC styles header with dropdown menus instead of side navigation
  • Add standard public RAC footer and secondary footer with links to Docs Site Aurora user guide and digital transfer guide
  • Use HTML progress element instead of Bootstrap progressbar in transfer table.
  • Remove tab interface on /transfers page and /accession page.
  • Add a new /accession/saved page for Saved Accessions
  • Replace /appraise page transfer details modal with a link in the table to the transfer details page.
  • Remove pointer row script that allowed users to select an entire row as a link. Hard to make that work with assistive tech. Replaced with a value in table rows that serves as a link to more details.
  • Improve alert pattern for aria-live announcements and to make all alerts manually dismissible so that they do not disappear without user action (both for improved accessibility).
  • Implement focus management when things are deleted in the DOM.
  • Fix delete_object_js script for Bagit and Rights org tables so that "there are no existing..." paragraph appears when table is deleted.
  • Restructure BagIt Profile creation form to use fieldsets (checkboxes and radio buttons) instead of multiple select inputs for certain form fields. Remove formsets that were associated with the old approach.
  • Simplify dashboard on homepage to remove chart.js, but still include useful data and add a hero with cta links.

Style Library updates

See styles repo PR 235 for associated updates made to style library based on its implementation in Aurora.

Other considerations

We have implemented Datatables serverside in Aurora. If we anticipate 1000s of rows of data (which we may, over time!) this makes sense. Otherwise, I'm not sure we need that and it could make maintaining local Datatables functionality easier to use a client side implementation. I haven't changed the implementation here, though. Could be worth revisiting as part of issue #646 .

@HaSistrunk
Copy link
Member Author

HaSistrunk commented Jan 7, 2025

Changes implemented after usability testing:

  • Remove "required" on bag-it profile metadata form fields. This was causing an issue in editing an existing bag-it profile where a blank form field is added to the bottom of the form automatically, and then prevents the user from saving the edited form since that field is required before saving changes.
  • Enable donor users to see "Saved Accessions" page (only the accessions from the user's org). Also updated fixtures to be able to test this in the app.
  • Change header nav for donor users so that "My Organization" (/orgs/pk) is now under "My Profile" menu.
  • Add DART docs link to footer

@helrond would you mind reviewing my last two commits related to allowing donor users to see the Saved Accessions to make sure I didn't miss anything?

Copy link
Member

@helrond helrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing.

bag_transfer/accession/views.py Show resolved Hide resolved
@HaSistrunk HaSistrunk deployed to development January 22, 2025 19:26 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants