Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/disk checker #2

Open
wants to merge 5 commits into
base: ros-devel
Choose a base branch
from
Open

Feat/disk checker #2

wants to merge 5 commits into from

Conversation

rcartarobotnik
Copy link

@rcartarobotnik rcartarobotnik commented Jan 29, 2025

This pull request includes several changes to the record_audio package to improve disk usage management and update configuration handling. The most important changes include adding disk usage checks before and during recording, loading configuration parameters from a YAML file, and updating the package metadata.

Disk usage management improvements:

  • script/record_audio.py: Added disk usage checks before starting a recording and during the recording process to ensure there is sufficient disk space. This includes calculating theoretical remaining space and stopping the recording if disk space is running out. [1] [2] [3] [4] [5]

Configuration handling improvements:

  • config/default.yaml: Added configuration parameters such as device, folder_path, format, microphone_rate, max_disk_usage, and max_disk_usage_recording.
  • launch/record_launch.launch: Modified the launch file to load parameters from the YAML configuration file instead of defining them directly in the launch file.

Package metadata update:

  • package.xml: Updated the package version to 0.1.0 and added an additional maintainer.

@rafa-martin rafa-martin changed the base branch from main to ros-devel January 30, 2025 07:13
config/default.yaml Outdated Show resolved Hide resolved
script/record_audio.py Outdated Show resolved Hide resolved
script/record_audio.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants