Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Mac packaging from Ventura to Sonoma #292

Merged

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Oct 2, 2024

Towards RobotLocomotion/drake#21978


This change is Reviewable

@BetsyMcPhail BetsyMcPhail added the blocked Not ready to merge or review label Oct 2, 2024
Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@mwoehlke-kitware for review. Merge needs to be coordinated with https://github.com/RobotLocomotion/drake-jenkins-jobs/pull/152 and RobotLocomotion/drake#21984

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @mwoehlke-kitware)

@jwnimmer-tri
Copy link
Contributor

Ping on this (& friends). The release ETA is next week, so we should try to get this merged this week.

Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Do you plan to remove Sonoma support later?

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BetsyMcPhail)

@BetsyMcPhail BetsyMcPhail removed the blocked Not ready to merge or review label Oct 7, 2024
Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the question?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BetsyMcPhail)

@BetsyMcPhail BetsyMcPhail merged commit 63099b6 into RobotLocomotion:main Oct 7, 2024
1 check passed
@BetsyMcPhail BetsyMcPhail deleted the mac-packaging-sonoma branch October 7, 2024 20:46
@mwoehlke-kitware
Copy link
Contributor

Sorry, I meant Ventura support. Ventura is still mentioned in two places.

@BetsyMcPhail
Copy link
Contributor Author

Yes, coming soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants