-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[roboteam_ai] Improve workflow with new docker structure #97
Conversation
It does not make sense to generate doxygen documentation for a PR. You only want to have documentation available for the current main branch. This can simply be updated on a push to the main branch.
…r convenient docker compose
Very nice 👍 , this will for sure make life a bit easier (software installation speedrun next transfer moment) I would add the installation to the readme as well (https://docs.docker.com/engine/install/ or https://docs.docker.com/engine/install/ubuntu/ and https://docs.docker.com/engine/install/linux-postinstall/) And the typo in the readme, docker compose instead of docker-compose In the game docker there still is secondary ai and autoref which we don't need during a game/demo |
Fixed |
I'm not entirely convinced by this PR. Please correct me if I'm wrong
The Dockerfile was initially written with the intent of having the |
We are not loosing any of the previous features, release container is still built and pushed on dockerhub as before ( Answering your second question, what we gain with this PR a definitely faster workflow for development as well as a reliable and reproducible environment that allows developers to build and test with a higher level of abstraction without loosing transparency or loosing the ability to execute manual grunt tasks. |
Improve workflow with new docker structure, see
docker/README.md