Comments and changes to DVL files #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added changes and comments to dvl_driver.py and main.py. Added dvl_dummy.ino for dummy data and new readme.
albonkey
reviewed
Mar 1, 2022
|
|
||
| In the `main.py` file import either dvl_driver.py as DVL or dvl_test.py as DVL for testing purposes. | ||
|
|
||
| ## Getting Started |
There was a problem hiding this comment.
Don't think we need these requirements here, as we have them in the main readme
albonkey
reviewed
Mar 1, 2022
| - Ubuntu 18.04 | ||
| - Possibly [rosserial](http://wiki.ros.org/rosserial_arduino/Tutorials/Arduino%20IDE%20Setup) | ||
|
|
||
| ### To run the code |
There was a problem hiding this comment.
We will run dvl as it's own package, so there should be a different rosrun command for opening this node. We can look into it tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to dvl_driver.py because some parts of code was in python 3 and up.