Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rule to 4.4.2 Timeouts #88

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

emielsteerneman
Copy link
Contributor

This draft PR adds the following to section 4.4.2 Timeouts:

Any robot that has been physically interacted with during a timeout must be treated as substituted, as outlined in <<Robot Substitution, Robot Substitution>>. Such a robot must be either removed from the field or placed in the area defined in <<Robot Substitution, Robot Substitution>> before the Timeout phase ends.

@emielsteerneman emielsteerneman added the review wanted A review on the rule change formulation is requested label Jan 7, 2025
@emielsteerneman emielsteerneman self-assigned this Jan 7, 2025
chapters/gamestructure.adoc Outdated Show resolved Hide resolved
@tobiasheineken
Copy link
Contributor

I like the change. Do we also want a change to 3.2.6 to make clear moving a robot by hand is not acceptable during a match?

@emielsteerneman
Copy link
Contributor Author

emielsteerneman commented Jan 8, 2025

I like the change. Do we also want a change to 3.2.6 to make clear moving a robot by hand is not acceptable during a match?

At the risk of being pedantic:

  1. Does moving robots into the field during the time before the start signal or break fall under "match"?
  2. Moving by hand is acceptable when moving robots out of the field, though I get your point

Additionally, maybe I should reword substituted in the rule change with taken out of the field. Marking a robot as substituted also implies that during timeout, robots can only be taken out of the field by a robot handler. It may also be confusing with the rule Each team has 5 free substitutions per halftime. Does a robot marked for substitution during timeout count towards this? I'd say no, but it's still confusing.

Edit: Or does it actually mean Each team has 5 free substitution INTENTS per halftime, not counting when a robot drives itself to the exchange area to be picked up while the game continues?

@tobiasheineken @g3force

@g3force
Copy link
Member

g3force commented Jan 8, 2025

I'd say, a substitution INTENT is free. You can revoke it without loosing anything:

A substitution intent can be revoked unless the game was not already halted for substitution.

Once the intent is accepted by the GC, its converted into a substitution (which allows for arbitrary many robots to substitute). This counts towards your substitution budget.

@g3force
Copy link
Member

g3force commented Jan 8, 2025

I'd also change "substituted" to sth like:

Any robot that has been physically interacted with during a timeout must be taken out of the field. It can be brought in again as outlined in <<Robot Substitution, Robot Substitution>>.

@g3force
Copy link
Member

g3force commented Jan 8, 2025

Do we also want a change to 3.2.6 to make clear moving a robot by hand is not acceptable during a match?

Probably worth adding.
"The robotic equipment has to be fully autonomous" also has some room for interpretation. One could argue, that this means that all robots must be able to move (what we used to imply so far), but that's quite implicit.

Does moving robots into the field during the time before the start signal or break fall under "match"?

I'd say that's not match.
However, if we would want to be really strict, we could ask teams to move all robots to the substitution area before the match, so that the robots are forced to move.
That would be easier, if we'd had an explicit substitution area, though. Because than we would not even care, if the robots would not move. We could consider this next year, when we evaluate such an area.

@emielsteerneman
Copy link
Contributor Author

I reworded 4.4.2 Timeouts and added to 3.2.6 Autonomy

The robotic equipment has to be fully autonomous. Human operators are not permitted to enter any information to the system during a match, except in <<Overview, breaks>> or during a <<Timeouts,timeout>>. Additionally, robots may not be manually moved during any phase of the match, except for moving robots out of the field, or into the field as described in <<Robot Substitution, Robot Substitution>>. Disregarding this rule is considered <<Unsporting Behavior, unsporting behavior>>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tip: It is good practice to put each sentence on a separate line. That's easier to read and makes it easier to compare the GIT diff.

@tobiasheineken
Copy link
Contributor

Looks good to me, thank you!

@emielsteerneman emielsteerneman marked this pull request as ready for review January 13, 2025 22:57
@emielsteerneman emielsteerneman merged commit 3004f6d into master Jan 15, 2025
1 check passed
@emielsteerneman emielsteerneman deleted the 87-prevent-manual-movement-in-timeout branch January 15, 2025 08:49
@emielsteerneman emielsteerneman restored the 87-prevent-manual-movement-in-timeout branch January 15, 2025 08:49
@emielsteerneman emielsteerneman deleted the 87-prevent-manual-movement-in-timeout branch January 15, 2025 08:50
kkimurak pushed a commit to kkimurak/ssl-rules-ja that referenced this pull request Jan 15, 2025
* Added rule to 4.4.2 Timeouts

* Update chapters/gamestructure.adoc

Co-authored-by: Nicolai Ommer <[email protected]>

* reworded to remove 'substituted' to prevent confusion with the additional rules around substitution

* Added the disallowance of manually moving robots to the section Autonomy

---------

Co-authored-by: Emiel Steerneman <[email protected]>
Co-authored-by: Nicolai Ommer <[email protected]>
kkimurak added a commit to kkimurak/ssl-rules-ja that referenced this pull request Jan 18, 2025
* Added rule to 4.4.2 Timeouts (RoboCup-SSL#88)

* Added rule to 4.4.2 Timeouts
* Update chapters/gamestructure.adoc
  Co-authored-by: Nicolai Ommer <[email protected]>
* reworded to remove 'substituted' to prevent confusion with the additional rules around substitution
* Added the disallowance of manually moving robots to the section Autonomy
  Co-authored-by: Emiel Steerneman <[email protected]>
  Co-authored-by: Nicolai Ommer <[email protected]>

* 和訳

---------

Co-authored-by: Emiel Steerneman <[email protected]>
Co-authored-by: Emiel Steerneman <[email protected]>
Co-authored-by: Nicolai Ommer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted A review on the rule change formulation is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent teams from manually moving non-functional robots in Timeout phase
3 participants