Add metadata line to inline code spans #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
commented
Nov 10, 2023
| @@ -91,5 +91,11 @@ defmodule Acceptance.Ast.Lists.SpacedPendingTest do | |||
|
|
|||
| assert ast_from_md(markdown) == ast | |||
| end | |||
|
|
|||
| # remove after upgrading earmark_ast_dsl | |||
There was a problem hiding this comment.
|
Hi, thanks to something like this we'd be able to provide more useful warnings in ExDoc. See elixir-lang/ex_doc#1807. I opted to just pass line information to what I need at the moment which is inline code spans. Let me know if that is acceptable or if we're adding this, we should add it to as many places as possible. Another potential idea is to opt-in to returning this information, the option could start as, say, |
|
That was a nice addendum, I'll release ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.