Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mainly added
static
to member functions where applicable, as well asnoexcept
to move constructors.I also added the
explicit
keyword where preferable, while avoiding it in cases where the intent was clearly to facilitate logical conversions.Additionally, I added the
[[nodiscard]]
attribute where appropriate, given that I also noticed the use of[[maybe_unused]]
and thus assumed that the addition would be acceptable. This can always be removed if needed.I also adjusted some inclusion issues that could prevent compilation depending on the order in which the headers were included, without directly including
raylib-cpp.hpp
.There is also the addition of a few missing
const
qualifiers.Finally, I made a few adjustments to constructors, avoiding initialization in the constructor body via
set()
where possible.