fixed compiler warnings #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah shit, seems like the update example commit came in as well; forgot to change the branch. Anyway, I updated the example to reflect the corresponding C example and made the Makefile work (at least under Linux, if someone could test it under Win/Mac this would be great). The builtin debug an run functionality of VSCode should be workign correctly as well |
|
Also Build fails, for some reason it cant find the repository URL? |
|
Thanks so much for the updates. For the automated tests, it looks like GitHub Actions could use some updates. Going to merge this forwards! Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fixed the compiler warning about comparing that count
unsigned integerwith anintegerby simply casting it. This should cause no issue as there is a <0 check beforehand