Feat/migration scaffoler backend module http request #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Xantier
previously approved these changes
Apr 24, 2024
Xantier
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Let's name this file something else. It's a bit disingenuous to call this alpha if the plan is to deprecate every other option soon enough.
There was a problem hiding this comment.
@Xantier - I went ahead and renamed it "new-backend".
Xantier
reviewed
Apr 24, 2024
.changeset/chatty-crabs-remain.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@roadiehq/scaffolder-backend-module-http-request': patch | |||
There was a problem hiding this comment.
This should be a minor change here
Xantier
approved these changes
Apr 24, 2024
4 tasks
pjungermann
reviewed
Apr 24, 2024
Comment on lines
+57
to
+58
| cd packages/backend | ||
| yarn add @roadiehq/scaffolder-backend-module-http-request/alpha |
There was a problem hiding this comment.
Suggested change
| cd packages/backend | |
| yarn add @roadiehq/scaffolder-backend-module-http-request/alpha | |
| yarn --cwd packages/backend add @roadiehq/scaffolder-backend-module-http-request |
| const backend = createBackend(); | ||
| backend.add(import('@backstage/plugin-proxy-backend/alpha')); | ||
| backend.add(import('@backstage/plugin-scaffolder-backend/alpha')); | ||
| backend.add(import('@roadiehq/scaffolder-backend-module-http-request/alpha')); |
There was a problem hiding this comment.
Suggested change
| backend.add(import('@roadiehq/scaffolder-backend-module-http-request/alpha')); | |
| backend.add(import('@roadiehq/scaffolder-backend-module-http-request')); |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| export { scaffolderBackendModuleHttpRequest as default } from './module'; |
There was a problem hiding this comment.
This should be moved to the index.ts. Currently, it is not exported for users of the package.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ Checklist
yarn changesetin the root)