Merge pull request #1623 from RoadieHQ/sc-22754-make-url-work

Actually call the function to make the URL
RoadieHQ · Sep 18, 2024 · e2746f2 · e2746f2
2 parents 050f49c + 1e83f94
commit e2746f2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/cold-socks-know.md b/.changeset/cold-socks-know.md
@@ -0,0 +1,5 @@
+---
+'@roadiehq/backstage-plugin-argo-cd': patch
+---
+
+Modify linking functionality construction to construct the link
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "14 || 16 || 18"
+    "node": "14 || 16 || 18 || 20"
   },
   "scripts": {
     "dev": "concurrently \"yarn start\" \"yarn start-backend\"",

diff --git a/plugins/frontend/backstage-plugin-argo-cd/src/components/ArgoCDHistoryTable.tsx b/plugins/frontend/backstage-plugin-argo-cd/src/components/ArgoCDHistoryTable.tsx
@@ -58,7 +58,7 @@ export const ArgoCDHistoryTable = ({
       render: (row: any): React.ReactNode =>
         linkUrl ? (
           <Link
-            href={`${linkUrl}/applications/${
+            href={`${linkUrl(row)}/applications/${
               namespaced ? `${row.appNamespace}/${row.app}` : row.app
             }`}
             target="_blank"