Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IEEP to store enchantment seeds #531

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

mts2200
Copy link

@mts2200 mts2200 commented Oct 16, 2024

This PR will change the enchant seed storage to IEEP instead of a local file. To prevent this value from changing abruptly, it will be loaded from the file, and the file itself will be deleted.

@Roadhog360
Copy link
Owner

Isn't this going to delete existing player data? Remember the old code is saving the NBT to the player data, if you delete that file you are deleting the player data.(!!!)

@mts2200
Copy link
Author

mts2200 commented Oct 16, 2024

We deleteing only previos file with seed data

UPD:

Remember the old code is saving the NBT to the player data

No, its not. Its saving data to other file:
image
Like {bla-bla-bla-bla}.etfuturum

@Roadhog360
Copy link
Owner

Ah yes, I was wrong, the old code makes a new file, you are right. I will test your PR soon

@Roadhog360 Roadhog360 merged commit 8aaf5fe into Roadhog360:master Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants