Backport light level change from 1.18 #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just added the basic functionality like it is in 1.18. Do you want me to also add a dimension blacklist config (-1 and 1 by default) and a config for the light level, so it can be adjusted to something else then 0? Both I have in my own mod at the moment, but it's unused. |
|
Can confirm this SHOULD work, doing the same thing in GT6 and it works nicely. |
makamys
reviewed
Feb 8, 2024
src/main/java/ganymedes01/etfuturum/configuration/configs/ConfigEntities.java
Outdated
Show resolved
Hide resolved
Co-authored-by: makamys <[email protected]>
…Futurum-Requiem into feat/lightlevel0
Pilzinsel64
changed the title
|
Why isn't this available. |
|
It doesn't work |
|
I ended up wanting a mixin implementation for better compatibility but I can't get the mixin to actually function properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the light level to 0 for mobs. Like in Minecraft 1.18+.
The config is false by default. Not sure if I should set it to true. Your decision.