Make chat & betterfps warnings translatable #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roadhog360
requested changes
Nov 5, 2023
| efr.prerelease.version=§c§l[Debug]: §rYou are using a pre-release version of §bEt §bFuturum §bRequiem§r. This version might not be stable, click here to go to GitHub to report bugs. | ||
| efr.WARN.prerelease.version=WARNING: a pre-release version of Et Futurum Requiem is in use! This build may not be stable, expect more bugs than usual. | ||
| efr.WARN.prerelease.version.bugs=Be sure to report bugs at https://github.com/Roadhog360/Et-Futurum-Requiem/issues |
There was a problem hiding this comment.
Capitalization inconsistency, all keys should follow a lower_snake_case format between each dot
|
|
||
| efr.prerelease.version=§c§l[Debug]: §rYou are using a pre-release version of §bEt §bFuturum §bRequiem§r. This version might not be stable, click here to go to GitHub to report bugs. | ||
| efr.WARN.prerelease.version=WARNING: a pre-release version of Et Futurum Requiem is in use! This build may not be stable, expect more bugs than usual. |
There was a problem hiding this comment.
This key should contain "log", not "WARN",
| efr.decoration.only=Decoration only | ||
|
|
||
| efr.prerelease.version=§c§l[Debug]: §rYou are using a pre-release version of §bEt §bFuturum §bRequiem§r. This version might not be stable, click here to go to GitHub to report bugs. |
There was a problem hiding this comment.
Does not describe that it's a warning. Should get "warn" instead of the below key
| efr.WARN.prerelease.version=ВНИМАНИЕ: используется предварительная версия Et Futurum Requiem! Эта сборка может быть нестабильной, ожидайте больше ошибок, чем обычно. | ||
| efr.WARN.prerelease.version.bugs=Обязательно сообщайте об ошибках по адресу https://github.com/Roadhog360/Et-Futurum-Requiem/issues. | ||
| efr.CRITICAL.badBetterFPSAlgorithm1=§4§l[КРИТИЧНО]: §bBetterFPS §rнастроен с плохим алгоритмом. | ||
| efr.CRITICAL.badBetterFPSAlgorithm2= "rivens-half" или "taylors" не должны использоваться для предотвращения ущерба вашему миру. Настоятельно рекомендуется зайти в его конфигурацию и изменить "алгоритм" на что-нибудь другое, желательно "vanilla". |
There was a problem hiding this comment.
"алгоритм" in quotes should be "algorithm", config values are not translated, there is only a "algorithm" option, no "алгоритм" option
|
@Roadhog360, ? |
|
BetterFPS keys still contain capital letters |
Roadhog360
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only pull request, where I don't ask a question.