Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Add conditional package reference to console project #16

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Code Quality: Add conditional package reference to console project #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
422d860
Add conditional package reference
Lamparter Feb 2, 2025
c2eeef1
Add deterministic build to MSBuild properties
Lamparter Feb 2, 2025
e37f278
Add ` /p:GITHUB_ACTIONS=true` argument to CI run
Lamparter Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
dotnet-version: '9.0.x'

- name: Restore dependencies
run: dotnet restore
run: dotnet restore /p:GITHUB_ACTIONS=true

- name: Build
run: dotnet build --configuration ${{ matrix.configuration }} --no-restore
run: dotnet build --configuration ${{ matrix.configuration }} --no-restore /p:GITHUB_ACTIONS=true

test:
name: Test
Expand All @@ -52,4 +52,4 @@ jobs:
dotnet-version: '9.0.x'

- name: Test
run: dotnet test --configuration Release --verbosity normal
run: dotnet test --configuration Release --verbosity normal /p:GITHUB_ACTIONS=true
7 changes: 6 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,9 @@
<DisplayVersion Condition="'$(ReleaseLevel)' != 'final'">$(DisplayVersion)-$(ReleaseLevel)$(BetaVersion)</DisplayVersion>
<Version>$(DisplayVersion)</Version>
</PropertyGroup>
</Project>

<!-- Deterministic build -->
<PropertyGroup Condition="'$(TF_BUILD)' == 'true' or '$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
</Project>
9 changes: 9 additions & 0 deletions src/Riverside.JsonBinder.Console/Riverside.JsonBinder.Console.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,13 @@
<PackageReference Include="Riverside.JsonBinder" Version="$(DisplayVersion)" />
</ItemGroup>

<ItemGroup Condition="'$(ContinuousIntegrationBuild)' == 'true'">
<ProjectReference Include="..\Riverside.JsonBinder\Riverside.JsonBinder.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(ContinuousIntegrationBuild)' != 'true'">
<ProjectReference Condition="'$(Configuration)' == 'Debug'" Include="..\Riverside.JsonBinder\Riverside.JsonBinder.csproj" />
<PackageReference Condition="'$(Configuration)' == 'Release'" Include="Riverside.JsonBinder" Version="$(DisplayVersion)" />
</ItemGroup>

</Project>
Loading