Skip to content

Commit

Permalink
update news
Browse files Browse the repository at this point in the history
  • Loading branch information
DivadNojnarg committed Jan 23, 2024
1 parent d1bdb84 commit 5aeddab
Showing 1 changed file with 29 additions and 2 deletions.
31 changes: 29 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,35 @@

- Fix #302: both `dashboardSidebar()` and `dashboardControlbar()` default __skin__ value is NULL.
This allows them to inherit from the parent `dashboardPage()` __dark__ parameter and have either
a full light or full dark skin. If not NULL, the corresponding skin is applied, regardless of the
parent `dashboardPage()`.
a full light or full dark skin. Therefore, it won't be possible anymore to apply a light sidebar background with the `dashboardPage()` when the main theme is dark and inversely. If you want to do so, you have to set `dark = NULL`, for instance:

```r
library(shiny)
library(bs4Dash)

shinyApp(
ui = dashboardPage(
dark = NULL,
header = dashboardHeader(
title = dashboardBrand(
title = "My dashboard",
color = "primary",
href = "https://adminlte.io/themes/v3",
image = "https://adminlte.io/themes/v3/dist/img/AdminLTELogo.png"
)
),
sidebar = dashboardSidebar(skin = "dark"),
body = dashboardBody(
box(status = "danger"),
box(status = "primary"),
box(status = "orange")
),
controlbar = dashboardControlbar(skin = "dark"),
title = "DashboardPage"
),
server = function(input, output) { }
)
```

## Bug fixes
- Remove unused `headTitles` parameter from `bs4Table()`.
Expand Down

0 comments on commit 5aeddab

Please sign in to comment.