Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: transport channel pool #562

Merged
merged 24 commits into from
Mar 28, 2024
Merged

feat: transport channel pool #562

merged 24 commits into from
Mar 28, 2024

Conversation

RyanKung
Copy link
Member

@RyanKung RyanKung commented Mar 12, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  1. set DEFAULT_TTL_MS: to 600 * 1000;
  2. dont print whole payload on debug log
  3. use ProviderRef in wasm envirement for avoid ownership issuse (may cause undefined here)
  4. use request_internal instead of request to avoid multi-serde from js and wasm
  5. RoundRobin pool for datachannel

@RyanKung RyanKung force-pushed the feat_transport_channel_pool branch 2 times, most recently from 7166252 to 9fe32df Compare March 17, 2024 13:47
@RyanKung RyanKung changed the title Feat transport channel pool feat: transport channel pool Mar 17, 2024
@RyanKung RyanKung force-pushed the feat_transport_channel_pool branch from cdafae1 to 67d96bf Compare March 28, 2024 04:03
@RyanKung RyanKung requested a review from Ma233 March 28, 2024 04:29
@RyanKung RyanKung merged commit 05b1739 into master Mar 28, 2024
5 checks passed
@RyanKung RyanKung deleted the feat_transport_channel_pool branch March 28, 2024 08:59
@RyanKung RyanKung mentioned this pull request Mar 28, 2024
Merged
RyanKung added a commit that referenced this pull request Mar 28, 2024
@RyanKung
bump version to 0.6.0 (#563)
034a47e 
Key changes:

Feature: data channel pool: #562
Feature: Using callback instead MPMC channel: #561
Chore: Make rings-snark optional: #558
Chore: Using forked protocolJs: #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma233 Ma233 Ma233 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanKung @Ma233