Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make snark optional #558

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

RyanKung
Copy link
Member

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

🟤 What is the current behavior? (You can also link to an open issue here)

🟢 What is the new behavior (if this is a feature change)?

☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

ℹ️ Other information

Closes #issue

Copy link
Member

@Ma233 Ma233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanKung RyanKung merged commit 43dda19 into RingsNetwork:master Feb 21, 2024
5 checks passed
RyanKung added a commit to RyanKung/rings-node that referenced this pull request Mar 17, 2024
* chore: make snark optional
* feat: support llvm wasm compiler
RyanKung added a commit that referenced this pull request Mar 28, 2024
Key changes:

Feature: data channel pool: #562
Feature: Using callback instead MPMC channel: #561
Chore: Make rings-snark optional: #558
Chore: Using forked protocolJs: #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants