chore: add CI checking for node ffi #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanKung
changed the title
RyanKung
reviewed
Oct 30, 2023
RyanKung
reviewed
Oct 30, 2023
.github/workflows/auto-release.yml
Outdated
There was a problem hiding this comment.
We also need to make rings.h and rings_node.dylib downloadable.
RyanKung
reviewed
Oct 30, 2023
Ma233
force-pushed
the
master
branch
2 times, most recently
from
07fd982
to
8c16056
Compare
RyanKung
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR added a simple smoke test for ffi feature.
🟤 What is the current behavior? (You can also link to an open issue here)
🟢 What is the new behavior (if this is a feature change)?
☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
ℹ️ Other information
Closes #issue