feature: split Transaction from MessagePayload #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR moves the message packing and verification logic from
MessagePayload
toTransaction
.Now, the
MessagePayload
only works for transferring messages.This PR also removed the generic type
T
from theMessagePayload
struct since it does not care about the type when transferring and verifying. Instead, theT
type was moved to thenew
method, and the data is serialized immediately upon creating the struct.🟤 What is the current behavior? (You can also link to an open issue here)
origin_verification
field andverification
field appear strangely in MessagePayload.addr
field is ambiguous, you have to understand it from the comments.🟢 What is the new behavior (if this is a feature change)?
The
Transaction
that is used to hold a verified message can be constructed separately.Users can create the
MessagePayload
at a later time when they want to transfer aTransaction
.☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking change.
ℹ️ Other information
Closes #issue