refactor: separated transport crate #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma233
force-pushed
the
refactor
branch
3 times, most recently
from
fbece07
to
4c16275
Compare
Ma233
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR separated the whole transport module of rings-core crate into an individual crate.
The new rings-transport crate provided:
Transportto hold all connections.Connectionwork as the oldTransportobjects.Callbacktrait andBoxedCallbacktrait object to help invoker pass callbacks to the Connection.🟤 What is the current behavior? (You can also link to an open issue here)
The maintenance of Transport and the behavior of rings network are both managed in swarm.
🟢 What is the new behavior (if this is a feature change)?
It allows the swarm to focus solely on network behavior (which may be divided into multiple protocols in the future 😄).
Supposed to have no new feature since this is a refactor.
☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Still WIP.
ℹ️ Other information
Closes #issue