Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get transport connection stats #452

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

Ma233
Copy link
Member

@Ma233 Ma233 commented Jul 6, 2023

I found that this API provides information similar to chrome://webrtc-internals when attempting to resolve issue #445.
It is particularly helpful when you are not working within the Chrome UI.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR export get_stats method of RtcPeerConnection to Transport, allowing for easy data manipulation through json serialization.

🟤 What is the current behavior? (You can also link to an open issue here)

Cannot inspect transport stats. Can only get its connection state.

🟢 What is the new behavior (if this is a feature change)?

Can get stats by invoke get_sats method of Transport.

☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No breaking change.

ℹ️ Other information

The docs of RTCPeerConnection.get_stats method: https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/getStats

Closes #issue

@Ma233
Copy link
Member Author

Ma233 commented Jul 6, 2023

This PR also adds additional logs for the unstable test_processor_connect_with_did test and removes the stabilization daemon, potentially making it easier to pass.
Even if it failed again, we can look at its stats now 🤣 .

@RyanKung
Copy link
Member

RyanKung commented Jul 6, 2023

COOL

@Ma233 Ma233 merged commit ee5ab25 into RingsNetwork:master Jul 6, 2023
@Ma233 Ma233 deleted the transport branch July 6, 2023 05:24
@Ma233 Ma233 changed the title feature: get transport connection stats feat: get transport connection stats Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants