feat!: export core Error to WASM and update browser Client creation API #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanKung
approved these changes
Jul 3, 2023
Ma233
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
rings_core::errtorings_core::errorto obey the naming convention of other crates.Into<JsValue>for core Error to achieve exporting function that return a Result include it.🟤 What is the current behavior? (You can also link to an open issue here)
When creating browser Client, user have to pass in SessionManagerBuilder rather than SessionManager as parameter.
🟢 What is the new behavior (if this is a feature change)?
They can build SessionManager and pass it as parameter.
☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes, user have to update browser Client creation parameter.
ℹ️ Other information
Closes #446