feat: implementation of correct chord #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r function 3) Some document for swarm and swarm builder
Ma233
reviewed
Jul 7, 2023
RyanKung
changed the title
Ma233
changed the title
Ma233
approved these changes
Jul 14, 2023
| @@ -41,7 +41,8 @@ node = [ | |||
| "wasmer-types", | |||
| ] | |||
| browser = [ | |||
| "console_error_panic_hook", | |||
| "backtrace", | |||
| "clap", | |||
There was a problem hiding this comment.
Strange clap dependency here for browser.
There was a problem hiding this comment.
I think there will only be a few traits (by derive) implemented here, and the compiler will help me optimize (cut) them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature and Docs update and Bug Fix
🟤 What is the current behavior? (You can also link to an open issue here)
For [feature="wasm"], if there is no message in the data channel, it should respond with Ok(None) instead of Err(e) (core/src/channels/wasm.rs).
For [feature="default"], the transformed Error should include the original error as the reasoning.
MessageHandlerEvent should be available to process without a context.
The DHT action handler should be implemented separately and included in the message handler.
🟢 What is the new behavior (if this is a feature change)?
[Feat]: New feature flag: experimental, mark an implementation as experimental, which means that:1) It may not have been thoroughly tested. 2)The corresponding API may be deprecated or adjusted in the future.
[Doc]: Added document for modules.
[Refactor]: Made MessageHandlerEvent context-agnostic.
[Refactor]: Convergent implementation of logging module for wasm and defaut. Convergent implementation of WASM and NATIVE #453
[Refactor]: Rename relay.sender() to relay.origin_sender()
[Refactor]: Reimplemented node::error::Error::code with #[repr(u32)]
[Fixed] datachannel for wasm and default
[Feat] Implemented messagehandler for correct chord related message. Correctness of DHT #388 [BUG] DHT Join may not work properly #387
☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
ℹ️ Other information
Closes #issue