Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress misleading "failed" messages for already existing IMDb ratings and watch history entries #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AliAlboushama
Copy link

@AliAlboushama AliAlboushama commented Feb 22, 2025

Description

This PR fixes an issue where the script logs "Failed" messages when an item already exists in IMDb Ratings or IMDb Watch History. Since this is not an actual error, the script now logs an informational message instead and skips re-adding the item.

Fixes

  • Added a check to detect existing IMDb ratings and watch history entries.
  • If an entry is already present, it now logs:

    "Episode/Movie already exists in IMDb Ratings/Watch History: [Title] ([Year]). Skipping..."

  • Removed unnecessary error logging for these cases.

Related Issue

Fixes #146

…n item already exists in IMDb watch history. Since this is not an actual error, the script now logs an informational message instead and skips re-adding the item.

Fixes:

Added a check to detect existing IMDb watch history entries.

If an entry is already present, it now logs:"Episode/Movie already exists in IMDb watch history: [Title] ([Year]). Skipping..."

Removed unnecessary error logging for these cases.

This improves script clarity by preventing false negatives and ensures cleaner logs.
@AliAlboushama AliAlboushama changed the title Suppress misleading "failed" messages for already existing IMDb watch history entries Suppress misleading "failed" messages for already existing IMDb ratings and watch history entries Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants