This repository has been archived by the owner on Jan 11, 2019. It is now read-only.
Add ability to be used as a Yeoman generator #105
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables use of the project as a Yeoman generator. Tries to leave the project structure as close to the original as possible.
My suggestion, though, would be to release version
6.0.0
that is not backward compatible with the current structure, and go all in on Yeoman. You may not want to make that big of a change, but cloning a starter kit and changing it is kind of a weird pattern and the current setup doesn't really allow people to make changes to their configuration, which is something that Yeoman would allow you to configure on installation, which would be pretty sweet. If you were interested in that kind of more-drastic change, I would be happy to add to this PR to make that happen.The major change, if you were to do that, would be moving the current root of the project under either
app/
orgenerators/app
(depends on your preferences). That's really all that has to change, although you could start to build up features that are provided by the user at installation time (like setting the name of the project in thepackage.json
dynamically).Changes
package.json
file to provide the requirements for the YeomanTesting the Generator
yeoman
npm link
in the repo, which will add it to the list of generators available toyeoman
yo
in the directory that you want to create a new project, and choose the option forReact Isomorphic Starterkit
Closes #2