Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat provider #618

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Feat provider #618

merged 8 commits into from
Aug 20, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Aug 20, 2024

Purpose of this Pull Request

This pull request accomplishes three main objectives:

  • Introduction of the Provider widget for data sharing between sub-trees.
  • Utilization of Provider to streamline theme management:
    • Enables direct modification of the theme in place at runtime without complete replacement.
    • Eliminates the need for FullTheme and InheritTheme; any component of the Theme, such as Palette, can now directly overwrite the Theme.
  • Simplification of the Overlay functionality, as overlay querying in event callbacks is now supported.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 20, 2024
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 20, 2024
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 20, 2024
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 20, 2024
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 20, 2024
Removed `FullTheme` and `InheritTheme`, now only using `Theme`.
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 20, 2024
…ent callbacks

BREAKING CHANGE: 🧨 Removed `Overlay::new_with_handle`, `OverlayCloseHandle` and
`OverlayStyle`
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 20, 2024
@M-Adoo M-Adoo merged commit bb5710f into RibirX:master Aug 20, 2024
7 checks passed
@M-Adoo M-Adoo deleted the feat-provider branch August 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant