Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/simplify type convert #612

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Aug 1, 2024

Purpose of this Pull Request

  • All implicit child conversions have been removed, except for conversions to Widget.
  • Lazy build the widget tree.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

These traits are used to support parent widgets in composing child
widgets and allow types to be converted into a child widget.
…ith child widgets.

Merge SingleWithChild, MultiWithChild, and ComposeWithChild into a single trait called WithChild.
Remove SingleParent and MultiParent traits.
Allow only the child to be converted to a widget or a type that implements the Into trait.
@github-actions github-actions bot force-pushed the refactor/simplify-type-convert branch from 7faa51b to 1e14d3b Compare August 1, 2024 10:20
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 1, 2024
@M-Adoo M-Adoo force-pushed the refactor/simplify-type-convert branch from 1e14d3b to 0b349df Compare August 1, 2024 10:25
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 1, 2024
@github-actions github-actions bot force-pushed the refactor/simplify-type-convert branch from 0b349df to ba8e23d Compare August 1, 2024 10:26
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 1, 2024
@M-Adoo M-Adoo force-pushed the refactor/simplify-type-convert branch from ba8e23d to 186a071 Compare August 1, 2024 10:30
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 1, 2024
@github-actions github-actions bot force-pushed the refactor/simplify-type-convert branch from 186a071 to 227723a Compare August 1, 2024 10:30
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 1, 2024
@M-Adoo M-Adoo force-pushed the refactor/simplify-type-convert branch from 227723a to 42f38c2 Compare August 1, 2024 11:33
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 1, 2024
@github-actions github-actions bot force-pushed the refactor/simplify-type-convert branch from 42f38c2 to 172b97b Compare August 1, 2024 11:33
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 1, 2024
@M-Adoo M-Adoo force-pushed the refactor/simplify-type-convert branch from 172b97b to 0242333 Compare August 1, 2024 13:44
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Aug 1, 2024
@github-actions github-actions bot force-pushed the refactor/simplify-type-convert branch from 0242333 to 194920e Compare August 1, 2024 13:44
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Aug 1, 2024
@M-Adoo M-Adoo marked this pull request as ready for review August 1, 2024 13:47
@M-Adoo M-Adoo merged commit d92c52e into RibirX:master Aug 1, 2024
14 checks passed
@M-Adoo M-Adoo deleted the refactor/simplify-type-convert branch August 1, 2024 13:55
@M-Adoo M-Adoo mentioned this pull request Aug 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant