Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bots prompt multi model #66

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Feat/bots prompt multi model #66

merged 8 commits into from
Jan 29, 2024

Conversation

sologeek
Copy link
Contributor

No description provided.

@sologeek sologeek requested a review from wjian23 January 22, 2024 04:45
let req = { create_text_request(&info.read(), bot_id) };
let req = create_text_request(&info.read(), bot_id);

println!("request content: {}", content);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug code of println?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for MingGe debug send message with context is or right

.msgs()
.iter()
.rev()
.skip(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the msg iter can be pass from the caller, skip(2) is odd

@@ -183,4 +192,28 @@ pub mod launch {
.write_all(content.as_bytes())
.expect("can't write bot.json");
}

pub fn copy_static_files_to_user_data() {
let mut src = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CARGO_MANIFEST_DIR valid after pack to install package

} else {
0
};
let last_idx = (channels.len() - 1).min(0);
Copy link
Contributor

@wjian23 wjian23 Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len() is unsize then len() - 1 may overflow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and min => max ?

@wjian23 wjian23 merged commit e53ec0c into main Jan 29, 2024
2 checks passed
@sologeek sologeek deleted the feat/bots-prompt-multi-model branch February 2, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants