Skip to content

Commit

Permalink
Removes unnecessary check that err file is empty after calibration
Browse files Browse the repository at this point in the history
  • Loading branch information
nawrockie committed Nov 14, 2023
1 parent d5cc371 commit 1c830b5
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions Rfam/Scripts/make/rfsearch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -655,9 +655,14 @@
if(! $do_all_local) { # job is running on the cluster
$calibrate_max_wait_secs = Bio::Rfam::Utils::wait_for_cluster_light($config, $user, \@jobnameA, \@outnameA, \@errnameA, "[ok]", $cmcalibrate_string, $logFH,
sprintf("[$ncpus_cmcalibrate procs, should take ~%.0f minute(s)]", $predicted_minutes), -1, $do_stdout);
Bio::Rfam::Utils::checkStderrFile($config->location, $calibrate_errO);
# if we get here, err file was empty, so we keep going
if(! $do_dirty) { unlink $calibrate_errO; } # this file is empty anyway

# we used to check the $calibrate_errO file here and die if it was
# not empty but we don't do that anymore because slurm MPI jobs
# output innocuous warnings to .err file and because
# wait_for_cluster_light() has already checked that the stdout has
# the success string. We also used to erase the err file here, but
# now we leave it
# if(! $do_dirty) { unlink $calibrate_errO; }
$calibrate_wall_secs = time() - $calibrate_start_time;
}
else { # job ran locally
Expand Down

0 comments on commit 1c830b5

Please sign in to comment.