Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed organelle suggestion suggesting the nucleus too early #5802

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

hhyyrylainen
Copy link
Member

Brief Description of What This PR Does

when it isn't actually good. This was caused by the player population clamp step affecting the score.

Thanks to a provided save I was able to easily test this and I came up with this fix idea after a few days of mostly passive thinking about this

Related Issues

closes #5799

and probably also #5800 but I'll leave that open for now

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

when it isn't actually good. This was caused by the player population clamp step affecting the score.
@hhyyrylainen hhyyrylainen added this to the Release 0.8.1 milestone Jan 10, 2025
@hhyyrylainen hhyyrylainen requested review from a team January 10, 2025 10:19
@hhyyrylainen hhyyrylainen changed the title Fixed organelle suggestion suggesting the nucleus Fixed organelle suggestion suggesting the nucleus too early Jan 10, 2025
@hhyyrylainen hhyyrylainen merged commit 86f5886 into master Jan 10, 2025
4 checks passed
@hhyyrylainen hhyyrylainen deleted the 5799_improve_suggestion_sensibility branch January 10, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Suggestion results don't always make sense (suggests things that don't increase the prediction)
1 participant