Add Sulfur chunks and adjust chunk shaders #5744
Conversation
| @@ -2887,8 +3048,8 @@ | |||
| "Ambient": 0 | |||
| }, | |||
| "hydrogensulfide": { | |||
| "Amount": 0, | |||
| "Density": 0, | |||
| "Amount": 12500, | |||
There was a problem hiding this comment.
Why was hydrogensulfide added to the seafloor patch?
There was a problem hiding this comment.
I think there would be some H2S on the seafloor, from occasional hydrothermal vents or smokers (as not all vents are grouped together in one region) and from sulfur rocks and the microbes feeding on them. The amount added makes it scarce outside of the sulfur chunks.
There was a problem hiding this comment.
Then it would make more sense for sulfur to spread from the vents patch instead of being harcoded like that. But there's not enough time before tomorrow to include this change for 0.8.0.
| @@ -1796,8 +1888,8 @@ | |||
| "Ambient": 0 | |||
| }, | |||
| "hydrogensulfide": { | |||
| "Amount": 0, | |||
| "Density": 0, | |||
| "Amount": 17500, | |||
There was a problem hiding this comment.
And also in coastal? It is very much totally intentional game design (and maybe realism) that hydrogen sulfide is not everywhere so I highly question a PR adding sulfur chunks totally reworking the hydrogen sulfide gameplay.
There was a problem hiding this comment.
Yeah, fair enough. I'll remove this bit.
There was a problem hiding this comment.
I suppose this is fine enough now to merge so that this gets into the public test build.
I did notice a slight editor display problem where hydrogen sulfide doesn't show in the editor display for patches that are missing the cloud version. I'll open an issue for that separately.
Brief Description of What This PR Does
Adds floating chunks of sulfur.
Changes shaders and some models and textures for chunks.
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.