Made temperature local variance smaller in other patches (#5913)

so that thermosynthesis isn't accidentally very good in the colder patches
Revolutionary-Games · Feb 20, 2025 · aab9102 · aab9102
1 parent acf0b8e
commit aab9102
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 3 deletions.
diff --git a/simulation_parameters/Constants.cs b/simulation_parameters/Constants.cs
@@ -925,7 +925,6 @@ public static class Constants
     public const float OPTIMAL_THERMOPLAST_TEMPERATURE = 100.0f;
     public const float THERMOPLAST_GUI_MAX_TEMPERATURE = 140.0f;
 
-    public const float NOISE_EFFECT_ON_LOCAL_TEMPERATURE = 70.0f;
     public const float TEMPERATURE_CHANGE_TO_TEMPERATURE_MULTIPLIER = 40.0f;
     public const float THERMOPLAST_HEAT_UP_SPEED = 0.25f;
 

diff --git a/simulation_parameters/microbe_stage/biomes.json b/simulation_parameters/microbe_stage/biomes.json
@@ -205,6 +205,7 @@
       "PatchVents"
     ],
     "GasVolume": 1,
+    "TemperatureVarianceScale": 70,
     "Conditions": {
       "Chunks": {
         "floatingToxin": {
@@ -508,6 +509,7 @@
     ],
     "CompoundCloudBrightness": 2,
     "GasVolume": 1,
+    "TemperatureVarianceScale": 20,
     "Conditions": {
       "Chunks": {
         "floatingToxin": {
@@ -1511,6 +1513,7 @@
     },
     "CompoundCloudBrightness": 2.5,
     "GasVolume": 1,
+    "TemperatureVarianceScale": 15,
     "Conditions": {
       "Chunks": {
         "floatingToxin": {
@@ -2347,6 +2350,7 @@
     },
     "CompoundCloudBrightness": 2.5,
     "GasVolume": 1,
+    "TemperatureVarianceScale": 18,
     "Conditions": {
       "Chunks": {
         "floatingToxin": {

diff --git a/src/microbe_stage/Biome.cs b/src/microbe_stage/Biome.cs
@@ -37,6 +37,11 @@ public class Biome : IRegistryType
     /// </summary>
     public LightDetails Sunlight = new();
 
+    /// <summary>
+    ///   How much the temperature in this biome varies on a microscopic scale when moving around
+    /// </summary>
+    public float TemperatureVarianceScale = 5;
+
     public float CompoundCloudBrightness = 1.0f;
 
     /// <summary>
@@ -91,6 +96,12 @@ public void Check(string name)
                 "cloud brightness needs to be over 0");
         }
 
+        if (TemperatureVarianceScale < 0)
+        {
+            throw new InvalidRegistryDataException(name, GetType().Name,
+                "temperature variance scale needs to be over 0");
+        }
+
         TranslationHelper.CopyTranslateTemplatesToTranslateSource(this);
     }
 

diff --git a/src/microbe_stage/MicrobeHUD.cs b/src/microbe_stage/MicrobeHUD.cs
@@ -757,7 +757,11 @@ private void UpdateHeatHelperWidget(in Entity player)
             Constants.THERMOPLAST_MAX_ATP_TEMPERATURE, Constants.THERMOPLAST_GUI_MAX_TEMPERATURE);
 
         if (!float.IsNaN(previousTemperature))
-            heatAccumulationBar.UpdateIndicator(cellProperties.Temperature > previousTemperature + 0.00001f);
+        {
+            // Only show good indicator when temperature is going up and it is within the ATP generation range
+            heatAccumulationBar.UpdateIndicator(cellProperties.Temperature > previousTemperature + 0.00001f &&
+                cellProperties.Temperature >= Constants.THERMOPLAST_MIN_ATP_TEMPERATURE);
+        }
 
         previousTemperature = cellProperties.Temperature;
     }

diff --git a/src/microbe_stage/systems/MicrobeHeatAccumulationSystem.cs b/src/microbe_stage/systems/MicrobeHeatAccumulationSystem.cs
@@ -40,6 +40,7 @@ public class MicrobeHeatAccumulationSystem : AEntitySetSystem<float>
     private GameWorld? gameWorld;
 
     private float patchTemperatureMiddle;
+    private float temperatureVarianceScale = 1;
 
     public MicrobeHeatAccumulationSystem(World world, IParallelRunner runner) : base(world, runner,
         Constants.SYSTEM_EXTREME_ENTITIES_PER_THREAD)
@@ -77,7 +78,7 @@ public float SampleTemperatureAt(Vector3 position)
 
         var differenceFromMiddle = rawNoise - Constants.MICROBE_HEAT_NOISE_MIDDLE_POINT;
 
-        return patchTemperatureMiddle + differenceFromMiddle * Constants.NOISE_EFFECT_ON_LOCAL_TEMPERATURE;
+        return patchTemperatureMiddle + differenceFromMiddle * temperatureVarianceScale;
     }
 
     protected override void PreUpdate(float delta)
@@ -103,6 +104,8 @@ protected override void PreUpdate(float delta)
             return;
         }
 
+        temperatureVarianceScale = gameWorld.Map.CurrentPatch.BiomeTemplate.TemperatureVarianceScale;
+
         if (!gameWorld.Map.CurrentPatch.Biome.TryGetCompound(Compound.Temperature, CompoundAmountType.Current,
                 out var patchTemperature))
         {