Disallow gltf files (instead compressed .glb versions should be used) (…

…#4395) * Remove gltf from git LFS * Add a check to disallow .gltf files
Revolutionary-Games · May 30, 2023 · 54696ea · 54696ea
1 parent da63cdc
commit 54696ea
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -25,7 +25,6 @@ en.po text linguist-generated=false
 *.zip filter=lfs diff=lfs merge=lfs -text
 *.dae filter=lfs diff=lfs merge=lfs -text
 *.blend filter=lfs diff=lfs merge=lfs -text
-*.gltf filter=lfs diff=lfs merge=lfs -text
 *.glb filter=lfs diff=lfs merge=lfs -text
 *.bin filter=lfs diff=lfs merge=lfs -text
 *.fbx filter=lfs diff=lfs merge=lfs -text

diff --git a/RevolutionaryGamesCommon b/RevolutionaryGamesCommon
diff --git a/Scripts/CodeChecks.cs b/Scripts/CodeChecks.cs
@@ -29,7 +29,13 @@ public CodeChecks(Program.CheckOptions opts,
                     },
                     new BomChecker(BomChecker.Mode.Disallowed, FilesNotAllowedToHaveBom),
                     new CfgCheck(AssemblyInfoReader.ReadVersionFromAssemblyInfo()),
-                    new DisallowedFileType(".gd", ".mo"))
+                    new DisallowedFileType(".gd", ".mo", ".gltf")
+                    {
+                        ExtraErrorMessages =
+                        {
+                            { ".gltf", "glTF files should be compressed into .glb files to save space" },
+                        },
+                    })
             },
             { "compile", new CompileCheck() },
             { "inspectcode", new InspectCode() },
+1 −0		DevCenterCommunication/Models/StorageItemDTO.cs
+15 −1		ScriptsBase/Checks/FileTypes/DisallowedFileType.cs