-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of RCTEventEmitter in Android #961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some minor comments
...hases-ui/android/src/main/java/com/revenuecat/purchases/react/ui/PaywallFooterViewManager.kt
Outdated
Show resolved
Hide resolved
...urchases-ui/android/src/main/java/com/revenuecat/purchases/react/ui/events/OnDismissEvent.kt
Outdated
Show resolved
Hide resolved
...ive-purchases-ui/android/src/main/java/com/revenuecat/purchases/react/ui/PaywallEventName.kt
Outdated
Show resolved
Hide resolved
vegaro
pushed a commit
that referenced
this pull request
Apr 1, 2024
**This is an automatic release.** ### New Features * Add font support to presentPaywall (#948) via Cesar de la Vega (@vegaro) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.3.2 (#962) via RevenueCat Git Bot (@RCGitBot) * [Android 7.8.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.1) * [Android 7.8.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.0) * [Android 7.7.3](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.3) * [iOS 4.39.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.1) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.3.1 (#960) via RevenueCat Git Bot (@RCGitBot) * [Android 7.8.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.1) * [Android 7.8.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.0) * [Android 7.7.3](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.3) * [iOS 4.39.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.1) ### Other Changes * Remove usage of RCTEventEmitter in Android (#961) via Cesar de la Vega (@vegaro) * Fix pod install of sample when updating phc (#954) via Cesar de la Vega (@vegaro) --------- Co-authored-by: RevenueCat CI <[email protected]>
vegaro
added
pr:other
A code change that improves performance
and removed
pr:refactor
labels
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying against 0.74 RC with Bridgeless mode and the library doesn't work well on Android. The reason is that the library is using the deprecated RCTEventEmitter.
This PR DylanVann/react-native-fast-image#1032 is an example of another plugin making the same change