Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of RCTEventEmitter in Android #961

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Mar 26, 2024

I've been trying against 0.74 RC with Bridgeless mode and the library doesn't work well on Android. The reason is that the library is using the deprecated RCTEventEmitter.

This PR DylanVann/react-native-fast-image#1032 is an example of another plugin making the same change

@vegaro vegaro marked this pull request as ready for review March 27, 2024 11:56
@vegaro vegaro requested a review from a team March 27, 2024 11:56
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor comments

@vegaro vegaro enabled auto-merge (squash) March 27, 2024 13:26
@vegaro vegaro merged commit 92bddfc into main Mar 27, 2024
4 checks passed
@vegaro vegaro deleted the sdk-3393-fix-listeners-in-paywall-views branch March 27, 2024 13:39
vegaro pushed a commit that referenced this pull request Apr 1, 2024
**This is an automatic release.**

### New Features
* Add font support to presentPaywall (#948) via Cesar de la Vega
(@vegaro)
### Dependency Updates
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.3.2 (#962) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.8.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.1)
* [Android
7.8.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.0)
* [Android
7.7.3](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.3)
* [iOS
4.39.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.1)
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.3.1 (#960) via
RevenueCat Git Bot (@RCGitBot)
* [Android
7.8.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.1)
* [Android
7.8.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.0)
* [Android
7.7.3](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.3)
* [iOS
4.39.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.1)
### Other Changes
* Remove usage of RCTEventEmitter in Android (#961) via Cesar de la Vega
(@vegaro)
* Fix pod install of sample when updating phc (#954) via Cesar de la
Vega (@vegaro)

---------

Co-authored-by: RevenueCat CI <[email protected]>
@vegaro vegaro added pr:other A code change that improves performance and removed pr:refactor labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:other A code change that improves performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants