UI Preview Mode: mock products #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpallares
commented
Jan 30, 2025
ajpallares
commented
Jan 30, 2025
Comment on lines
303
to
313
| // For mocking purposes: all yearly subscriptions have a 1-week free trial | ||
| guard productType.period?.unit == .year else { return nil } | ||
| return TestStoreProductDiscount( | ||
| identifier: "intro", | ||
| price: 0, | ||
| localizedPriceString: "$0.00", | ||
| paymentMode: .freeTrial, | ||
| subscriptionPeriod: SubscriptionPeriod(value: 1, unit: .week), | ||
| numberOfPeriods: 1, | ||
| type: .introductory | ||
| ) |
There was a problem hiding this comment.
Based on @JayShortway's comment here, I'm only adding mocked introductory offers for yearly subscriptions
tonidero
reviewed
Jan 30, 2025
| } else { | ||
| packageType = .custom | ||
| } | ||
| return ProductTypeMock(packageType: packageType) ?? .default |
There was a problem hiding this comment.
Hmm I'm wondering if we should default always to a lifetime in this case.... But then again, I don't have a better alternative, so I think this is ok for now!
tonidero
approved these changes
Jan 30, 2025
facumenzella
reviewed
Feb 3, 2025
| @@ -12,7 +12,7 @@ | |||
| // Created by Juanpe Catalán on 9/8/21. | |||
|
|
|||
| import Nimble | |||
| @testable import RevenueCat | |||
| @testable @_spi(Internal) import RevenueCat | |||
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation
The UI Preview Mode of the SDK should limit all the functionality of the SDK to only enable implementing the Paywall Previews functionality in the RevenueCat app.
Description
Mock the
StoreProducts, as we cannot fetch them from StoreKit