Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Entitlements: Enable enforced mode #1485

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tonidero
Copy link
Contributor

Description

This adds the enforced mode to the public API. I've also retested it manually to make sure the behavior is expected.

  • Holding until we're ready to ship this.

@tonidero tonidero added HOLD pr:feat A new feature labels Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15660d7) 83.89% compared to head (bb740eb) 83.88%.

Files Patch % Lines
...s/common/verification/SignatureVerificationMode.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   83.89%   83.88%   -0.01%     
==========================================
  Files         212      212              
  Lines        7016     7018       +2     
  Branches     1013     1014       +1     
==========================================
+ Hits         5886     5887       +1     
  Misses        731      731              
- Partials      399      400       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HOLD pr:feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant