Add that revenue will always be reported in USD but can find the orig… #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inal currency in the field
|
Preview this PR here: https://dev-docs.revenuecat.com/pr-625/ |
pantelis-rc
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Left a small suggestion. Let's see what the decision is in the thread with @dpannasch
| @@ -44,7 +44,7 @@ The Amplitude integration tracks the following events: | |||
| | Product Change | rc_product_change_event | A subscriber has changed the product of their subscription. This does not mean the new subscription is in effect immediately. See [Managing Subscriptions](/subscription-guidance/managing-subscriptions) for more details on updates, downgrades, and crossgrades. | ✅ | ✅ | ❌ | ✅ | ❌ | | |||
|
|
|||
|
|
|||
| For events that have revenue, such as trial conversions and renewals, RevenueCat will automatically record this amount along with the event in Amplitude. | |||
| For events that have revenue, such as trial conversions and renewals, RevenueCat will automatically record this amount along with the event in Amplitude. Bear in mind that revenue will always be reported in USD. If it's been made with a different currency, we'll automatically convert it. You can find the currency of the original transaction in the `currency` field of the event. | |||
There was a problem hiding this comment.
(suggestion)(non-blocking) I think the second phrase can be removed or supplemented with "convert it to USD". While reading it, I interpreted "we'll automatically convert it" to mean convert it to the different currency.
HaleyRevcat
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For these 3 integrations, we always send the price converted to USD but we send the original currency. It is misleading and some customers believe that the revenue is in such currency.
This aims to clarify it and make sure developers know that is being send in USD.