Improve customer identity & configuring SDK flow #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR here: https://dev-docs.revenuecat.com/pr-601/ |
codykerns
changed the title
Jethro87
reviewed
Jan 16, 2025
There was a problem hiding this comment.
I like the new structure. Most of the requested changes are subtle grammar updates.
One larger piece of feedback I had is related to the "Listening for customer info updates" and "handling promoted purchases" sections for iOS and Android. These methods are also available in the hybrids, so I wonder if a section with code snippets for all would be a good idea.
codykerns
commented
Jan 16, 2025
codykerns
commented
Jan 16, 2025
codykerns
commented
Jan 16, 2025
codykerns
commented
Jan 16, 2025
codykerns
commented
Jan 16, 2025
codykerns
commented
Jan 16, 2025
codykerns
commented
Jan 16, 2025
codykerns
commented
Jan 16, 2025
Jethro87
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Description
Our current 'Identifying Customers' doc is ugly and has a lot of irrelevant information sprinkled throughout the 'normal' implementation flow
Additionally, our 'Configuring SDK' doc needed some restructuring
Changes introduced
Linear ticket (if any)
Additional comments