[WIP] This PR includes the lib-retroshare changes for the notify feature of wire #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@defnax Please review this also |
|
PYRET1C
changed the title
|
can you update your code to use late libretroshare? we are then testing with very outdated code then wire. |
|
@csoler needs to be checked |
|
can you merge this when its ok @csoler |
|
it still needs improvements. i will do them when i get time. I am sorry, i have been too busy past few months. |
|
this year? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues with the notify feature of wire which can be seen below on this PR:
RetroShare/RetroShare#2826