Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NameValueList equals, in case this is an empty NameValueList #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

macvoo
Copy link

@macvoo macvoo commented Feb 22, 2018

Calling NameListValue#equals on a empty NameValueList (handing over another NameValueList) would always return true in the current implementation.

CodeSample:
//Given:
NameValueList a = new NameValueList();
NameValueList b = new NameValueList();
b.set("someName", "someValue");
//When
a.equals(b); --> would be true, but should be false...

@gsaslis
Copy link
Contributor

gsaslis commented Feb 23, 2018

Hey @macvoo !

Thanks for taking the time to submit this PR ❤️ !!

Could you please take a look at our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with processing this?

Thanks in advance!
Yorgos

@gsaslis gsaslis requested a review from a team March 6, 2018 17:09
@gsaslis
Copy link
Contributor

gsaslis commented Mar 6, 2018

thanks for signing the CLA @macvoo !

Passing this on for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants